Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes releases < v0.20 #1416

Merged
merged 9 commits into from
Jun 12, 2024
Merged

Removes releases < v0.20 #1416

merged 9 commits into from
Jun 12, 2024

Conversation

ZPain8464
Copy link
Contributor

@ZPain8464 ZPain8464 commented May 20, 2024

This PR removes Core and Enterprise changelogs and upgrade guides up to v0.20. This PR only resolves the removal of older versions; it does not resolve the second requirement found in https://github.com/pomerium/internal/issues/1798.

Related to https://github.com/pomerium/internal/issues/1798.

@ZPain8464 ZPain8464 requested a review from a team as a code owner May 20, 2024 23:17
@ZPain8464 ZPain8464 requested review from cmo-pomerium and removed request for a team May 20, 2024 23:17
Copy link

netlify bot commented May 20, 2024

Deploy Preview for pomerium-docs ready!

Name Link
🔨 Latest commit 4577a7f
🔍 Latest deploy log https://app.netlify.com/sites/pomerium-docs/deploys/66631380edea9f000825631e
😎 Deploy Preview https://deploy-preview-1416--pomerium-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kenjenkins
Copy link
Contributor

It sounds like https://github.com/pomerium/internal/issues/1798 is describing the links shown at /docs/versions. I still see links going back as far as v0.10 there.

Copy link
Collaborator

@desimone desimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't think we need to scrub the changelog here but rather the versions link list.

@ZPain8464
Copy link
Contributor Author

Ah I see, I'll update this PR to remove the archived versions links up to v0.20, and restore the changelogs and upgrade guides.

@ZPain8464 ZPain8464 requested a review from desimone June 7, 2024 14:05
@ZPain8464
Copy link
Contributor Author

ZPain8464 commented Jun 7, 2024

@desimone and @kenjenkins I reverted the changelog and upgrade guide commits and removed archived versions < v0.20. Please let me know if this PR needs anything else.

@ZPain8464
Copy link
Contributor Author

@desimone looks like you need to approve the changes to merge.

@ZPain8464 ZPain8464 merged commit bf616f3 into main Jun 12, 2024
15 checks passed
@ZPain8464 ZPain8464 deleted the zpain/encourage-recent-versions branch June 12, 2024 15:41
backport-actions-token bot pushed a commit that referenced this pull request Jun 12, 2024
* removes core changelogs > 20

* removes Core upgrade guides < v0.20

* removes enterprise changelogs < v0.20

* removes enterprise changelogs < v0.20

* reverts 8ed8bd9

* Revert "removes enterprise changelogs < v0.20"

This reverts commit ee2d287.

* Revert "removes Core upgrade guides < v0.20"

This reverts commit d2f501e.

* Revert "removes core changelogs > 20"

This reverts commit 1dccedc.

* removes archived versions < v0.20
backport-actions-token bot pushed a commit that referenced this pull request Jun 12, 2024
* removes core changelogs > 20

* removes Core upgrade guides < v0.20

* removes enterprise changelogs < v0.20

* removes enterprise changelogs < v0.20

* reverts 8ed8bd9

* Revert "removes enterprise changelogs < v0.20"

This reverts commit ee2d287.

* Revert "removes Core upgrade guides < v0.20"

This reverts commit d2f501e.

* Revert "removes core changelogs > 20"

This reverts commit 1dccedc.

* removes archived versions < v0.20
backport-actions-token bot pushed a commit that referenced this pull request Jun 12, 2024
* removes core changelogs > 20

* removes Core upgrade guides < v0.20

* removes enterprise changelogs < v0.20

* removes enterprise changelogs < v0.20

* reverts 8ed8bd9

* Revert "removes enterprise changelogs < v0.20"

This reverts commit ee2d287.

* Revert "removes Core upgrade guides < v0.20"

This reverts commit d2f501e.

* Revert "removes core changelogs > 20"

This reverts commit 1dccedc.

* removes archived versions < v0.20
backport-actions-token bot pushed a commit that referenced this pull request Jun 12, 2024
* removes core changelogs > 20

* removes Core upgrade guides < v0.20

* removes enterprise changelogs < v0.20

* removes enterprise changelogs < v0.20

* reverts 8ed8bd9

* Revert "removes enterprise changelogs < v0.20"

This reverts commit ee2d287.

* Revert "removes Core upgrade guides < v0.20"

This reverts commit d2f501e.

* Revert "removes core changelogs > 20"

This reverts commit 1dccedc.

* removes archived versions < v0.20
backport-actions-token bot pushed a commit that referenced this pull request Jun 12, 2024
* removes core changelogs > 20

* removes Core upgrade guides < v0.20

* removes enterprise changelogs < v0.20

* removes enterprise changelogs < v0.20

* reverts 8ed8bd9

* Revert "removes enterprise changelogs < v0.20"

This reverts commit ee2d287.

* Revert "removes Core upgrade guides < v0.20"

This reverts commit d2f501e.

* Revert "removes core changelogs > 20"

This reverts commit 1dccedc.

* removes archived versions < v0.20
backport-actions-token bot pushed a commit that referenced this pull request Jun 12, 2024
* removes core changelogs > 20

* removes Core upgrade guides < v0.20

* removes enterprise changelogs < v0.20

* removes enterprise changelogs < v0.20

* reverts 8ed8bd9

* Revert "removes enterprise changelogs < v0.20"

This reverts commit ee2d287.

* Revert "removes Core upgrade guides < v0.20"

This reverts commit d2f501e.

* Revert "removes core changelogs > 20"

This reverts commit 1dccedc.

* removes archived versions < v0.20
backport-actions-token bot pushed a commit that referenced this pull request Jun 12, 2024
* removes core changelogs > 20

* removes Core upgrade guides < v0.20

* removes enterprise changelogs < v0.20

* removes enterprise changelogs < v0.20

* reverts 8ed8bd9

* Revert "removes enterprise changelogs < v0.20"

This reverts commit ee2d287.

* Revert "removes Core upgrade guides < v0.20"

This reverts commit d2f501e.

* Revert "removes core changelogs > 20"

This reverts commit 1dccedc.

* removes archived versions < v0.20
ZPain8464 added a commit that referenced this pull request Jun 12, 2024
Removes releases < v0.20  (#1416)

* removes core changelogs > 20

* removes Core upgrade guides < v0.20

* removes enterprise changelogs < v0.20

* removes enterprise changelogs < v0.20

* reverts 8ed8bd9

* Revert "removes enterprise changelogs < v0.20"

This reverts commit ee2d287.

* Revert "removes Core upgrade guides < v0.20"

This reverts commit d2f501e.

* Revert "removes core changelogs > 20"

This reverts commit 1dccedc.

* removes archived versions < v0.20

Co-authored-by: zachary painter <[email protected]>
ZPain8464 added a commit that referenced this pull request Jun 12, 2024
Removes releases < v0.20  (#1416)

* removes core changelogs > 20

* removes Core upgrade guides < v0.20

* removes enterprise changelogs < v0.20

* removes enterprise changelogs < v0.20

* reverts 8ed8bd9

* Revert "removes enterprise changelogs < v0.20"

This reverts commit ee2d287.

* Revert "removes Core upgrade guides < v0.20"

This reverts commit d2f501e.

* Revert "removes core changelogs > 20"

This reverts commit 1dccedc.

* removes archived versions < v0.20

Co-authored-by: zachary painter <[email protected]>
ZPain8464 added a commit that referenced this pull request Jun 12, 2024
Removes releases < v0.20  (#1416)

* removes core changelogs > 20

* removes Core upgrade guides < v0.20

* removes enterprise changelogs < v0.20

* removes enterprise changelogs < v0.20

* reverts 8ed8bd9

* Revert "removes enterprise changelogs < v0.20"

This reverts commit ee2d287.

* Revert "removes Core upgrade guides < v0.20"

This reverts commit d2f501e.

* Revert "removes core changelogs > 20"

This reverts commit 1dccedc.

* removes archived versions < v0.20

Co-authored-by: zachary painter <[email protected]>
ZPain8464 added a commit that referenced this pull request Jun 12, 2024
Removes releases < v0.20  (#1416)

* removes core changelogs > 20

* removes Core upgrade guides < v0.20

* removes enterprise changelogs < v0.20

* removes enterprise changelogs < v0.20

* reverts 8ed8bd9

* Revert "removes enterprise changelogs < v0.20"

This reverts commit ee2d287.

* Revert "removes Core upgrade guides < v0.20"

This reverts commit d2f501e.

* Revert "removes core changelogs > 20"

This reverts commit 1dccedc.

* removes archived versions < v0.20

Co-authored-by: zachary painter <[email protected]>
ZPain8464 added a commit that referenced this pull request Jun 12, 2024
Removes releases < v0.20  (#1416)

* removes core changelogs > 20

* removes Core upgrade guides < v0.20

* removes enterprise changelogs < v0.20

* removes enterprise changelogs < v0.20

* reverts 8ed8bd9

* Revert "removes enterprise changelogs < v0.20"

This reverts commit ee2d287.

* Revert "removes Core upgrade guides < v0.20"

This reverts commit d2f501e.

* Revert "removes core changelogs > 20"

This reverts commit 1dccedc.

* removes archived versions < v0.20

Co-authored-by: zachary painter <[email protected]>
ZPain8464 added a commit that referenced this pull request Jun 12, 2024
Removes releases < v0.20  (#1416)

* removes core changelogs > 20

* removes Core upgrade guides < v0.20

* removes enterprise changelogs < v0.20

* removes enterprise changelogs < v0.20

* reverts 8ed8bd9

* Revert "removes enterprise changelogs < v0.20"

This reverts commit ee2d287.

* Revert "removes Core upgrade guides < v0.20"

This reverts commit d2f501e.

* Revert "removes core changelogs > 20"

This reverts commit 1dccedc.

* removes archived versions < v0.20

Co-authored-by: zachary painter <[email protected]>
ZPain8464 added a commit that referenced this pull request Jun 12, 2024
Removes releases < v0.20  (#1416)

* removes core changelogs > 20

* removes Core upgrade guides < v0.20

* removes enterprise changelogs < v0.20

* removes enterprise changelogs < v0.20

* reverts 8ed8bd9

* Revert "removes enterprise changelogs < v0.20"

This reverts commit ee2d287.

* Revert "removes Core upgrade guides < v0.20"

This reverts commit d2f501e.

* Revert "removes core changelogs > 20"

This reverts commit 1dccedc.

* removes archived versions < v0.20

Co-authored-by: zachary painter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants