Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: updates sidebar and removes unnecessary k8s page #1221

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

ZPain8464
Copy link
Contributor

This is a house-cleaning PR that removes an unnecessary k8s page and sets the deploying.md page as the landing page when users navigate to Deploy in the sidebar.

@ZPain8464 ZPain8464 requested a review from a team as a code owner February 5, 2024 20:12
@ZPain8464 ZPain8464 requested review from cmo-pomerium and removed request for a team February 5, 2024 20:12
Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for pomerium-docs ready!

Name Link
🔨 Latest commit 2ec3f0e
🔍 Latest deploy log https://app.netlify.com/sites/pomerium-docs/deploys/65c24047b06e8200081ee754
😎 Deploy Preview https://deploy-preview-1221--pomerium-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sidebars.js Outdated
@@ -40,7 +41,7 @@ const sidebars = {
{
type: 'category',
label: 'Kubernetes',
link: {type: 'doc', id: 'docs/deploy'},
// link: {type: 'doc', id: 'docs/deploy'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can delete this line entirely, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. Done.

@ZPain8464 ZPain8464 merged commit ce73779 into main Feb 6, 2024
6 checks passed
@ZPain8464 ZPain8464 deleted the zpain/update-deploy-page branch February 6, 2024 14:22
backport-actions-token bot pushed a commit that referenced this pull request Feb 6, 2024
* updates sidebar and removes unnecessary k8s page

* removes commented line
ZPain8464 added a commit that referenced this pull request Feb 6, 2024
Docs: updates sidebar and removes unnecessary k8s page (#1221)

* updates sidebar and removes unnecessary k8s page

* removes commented line

Co-authored-by: zachary painter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants