cleanup connection messages #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desimone
reviewed
Jan 12, 2022
There was a problem hiding this comment.
I like the new error stems better, but could we keep the context as well in the log?
More generally. I think the intent here was to display structured (json) logs, our logging feels like we are going the other direction. From unstructured, forcing structure from error status enums.
|
destination address and listen address are available in the same window.
Structured logs could be converted into human readable ones. There's no usability improvement in presenting them as JSON. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cleanup connection state change messages
Related issues
Fixes https://github.com/pomerium/internal/issues/715
Checklist
improvement/bug/ etc)