Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add opinionated dev setup scripts #60

Merged
merged 2 commits into from
Dec 15, 2021
Merged

add opinionated dev setup scripts #60

merged 2 commits into from
Dec 15, 2021

Conversation

travisgroth
Copy link
Contributor

@travisgroth travisgroth commented Dec 14, 2021

Summary

The desktop client depends on the cli binary but may need development against an unreleased branch, commit, etc.

This PR adds a few yarn scripts to set up a checkout of the cli repo and maintain a build of the cli that yarn start will pick up during local development.

If we started persisting artifacts from every commit that lands on main in the cli repo, we could pull those by default. However, that wouldn't help in the case of an active PR or branch. Putting together some commands to easily build locally seemed like a good compromise that would address broader use cases.

Related issues

n/a

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@travisgroth travisgroth marked this pull request as ready for review December 15, 2021 19:27
@travisgroth travisgroth merged commit 849b90d into master Dec 15, 2021
@travisgroth travisgroth deleted the dev_setup branch December 15, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants