include github hash with version #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisgroth
reviewed
Dec 1, 2021
| @@ -37,7 +37,7 @@ const TopTabs = (): JSX.Element => { | |||
| </Grid> | |||
| <Grid item xs={2}> | |||
| <Typography align="center" variant="subtitle2"> | |||
| Version: {version} | |||
| Version: {cliVersion + ' ' + gitHash} | |||
There was a problem hiding this comment.
We should probably still include the main version. Something like:
Version: ${version}-${gitHash}
Pomerium-CLI Version: ${cliVersion}
There was a problem hiding this comment.
can you add it to the metadata then. it gives me warnings including from package.json
There was a problem hiding this comment.
i guess i can do it
also this is a design change and will look bad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Includes both github has and version in the top right of the app
Related issues
https://app.zenhub.com/workspaces/pomerium-5f0d1eec340a620025c4dfa0/issues/pomerium/internal/598
Checklist
improvement/bug/ etc)