Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable embedding build metadata such as
pomerium-cli
version or git commit hash. Unfortunately there's no particularly direct way to pass this information into an electron-builder application, so this PR places the information into a newmetadata.json
file. This file can then be referenced by the desktop UI elements similar topackage.json
.The benefit of using a new file over
package.json
is that we (a) don't have to rewrite an existing file, which feels wrong (b) can avoid accidentally persisting transient changes topackage.json
Details:
pomerium-cli
version to top levelpackage.json
./src/metadata.json
)metadata
command to run said script as a dependency foryarn build
/src/metadata.json
It should be easy to add other information such as build time.
This will need a minor rebase onto the in-progress UI refactor if it seems like a sane approach.