Version 0.0.2 #45
Merged
Version 0.0.2 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* generate via ts-proto * add grpc-js dep * fix tsc error * regenerate to pick up proto changes Co-authored-by: Travis Groth <[email protected]> Co-authored-by: wasaga <>
calebdoxsey
approved these changes
Dec 1, 2021
| return ( | ||
| <SvgIcon viewBox="0 0 20 20" className={classes.iconStyle}> | ||
| <path | ||
| d="M8.33317 3.3335H3.33317C2.4165 3.3335 1.67484 4.0835 1.67484 5.00016L1.6665 15.0002C1.6665 15.9168 2.4165 16.6668 3.33317 16.6668H16.6665C17.5832 16.6668 18.3332 15.9168 18.3332 15.0002V6.66683C18.3332 5.75016 17.5832 5.00016 16.6665 5.00016H9.99984L8.33317 3.3335Z" |
There was a problem hiding this comment.
where did these svgs come from? Maybe add a comment if it came from a library?
There was a problem hiding this comment.
no library. it is from the designer.
src/renderer/pages/ConnectForm.tsx
Outdated
| }; | ||
|
|
||
| const saveTags = (arr: string[]): void => { | ||
| setTags(arr.map((tag) => formatTag(tag))); |
There was a problem hiding this comment.
Suggested change
| setTags(arr.map((tag) => formatTag(tag))); | |
| setTags(arr.map(formatTag)); |
Comment on lines
56
to
58
| const [statuses, setStatuses] = useState( | ||
| {} as { [key: string]: ListenerStatus } | ||
| ); |
There was a problem hiding this comment.
Suggested change
| const [statuses, setStatuses] = useState( | |
| {} as { [key: string]: ListenerStatus } | |
| ); | |
| const [statuses, setStatuses] = useState<Record<string, ListenerStatus>>({}); |
There was a problem hiding this comment.
yup had copy pasted from the generated code
| const [statuses, setStatuses] = useState( | ||
| {} as { [key: string]: ListenerStatus } | ||
| ); | ||
| const [error, setError] = useState(null as ServiceError | null); |
There was a problem hiding this comment.
I think explicitly setting the generic type would be clearer in this case.
Suggested change
| const [error, setError] = useState(null as ServiceError | null); | |
| const [error, setError] = useState<ServiceError>(null); |
There was a problem hiding this comment.
it complains unless i do this:
const [error, setError] = useState<ServiceError | null>(null);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most Done. Planning to merge it so we can do smaller prs