Update Tooltip Helper Text #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfornuto
force-pushed
the
575-help-text
branch
from
13bf425
to
26c81fd
Compare
|
Per discussion in slack, the React fragments were indeed 馃憤 so I updated all the other tooltips for styling. |
nhayfield
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the tooltip text per feedback in https://github.com/pomerium/internal/issues/575. The updates are also made t the docs here.
This PR also updates the FieldWrapper component to so that the description field is of type ReactFragment, which lets us add text styling (among other things) to the help text. If this is 馃憤 I can also style the other descriptions the same way. If not I'll remove it and un-style the description I used it with.