Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump electron-rebuild from 2.3.5 to 3.2.9 #403

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

kenjenkins
Copy link
Contributor

@kenjenkins kenjenkins commented Apr 5, 2024

Summary

Bump electron-rebuild from 2.3.5 to 3.2.9.

This should remove a transitive dependency on the 'request' package, which has an open security alert and is no longer maintained: https://github.com/pomerium/desktop-client/security/dependabot/77.

It looks like this also removes a transitive dependency on the 'tough-cookie' package, which has an associated security alert as well: https://github.com/pomerium/desktop-client/security/dependabot/83.

Related issues

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

This should remove a transitive dependency on the 'request' package,
which has an open security alert and is no longer maintained.
@kenjenkins kenjenkins added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Apr 5, 2024
@kenjenkins kenjenkins requested review from a team as code owners April 5, 2024 00:58
@kenjenkins kenjenkins requested review from calebdoxsey and removed request for a team April 5, 2024 00:58
@kenjenkins kenjenkins merged commit 0ba9877 into main Apr 5, 2024
3 checks passed
@kenjenkins kenjenkins deleted the kenjenkins/update-electron-rebuild branch April 5, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants