UI for new client cert OS store options #391
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pomerium-cli
now has new options for searching the system trust store for a client certificate: by default it will look for a certificate matching any trusted CA names from the TLS handshake, but additionally it can filter by a single Issuer Name attribute and/or a single Subject Name attribute.Add corresponding UI to the Desktop Client:
--client-cert-from-store
CLI option)--client-cert-issuer
and--client-cert-subject
CLI options)Screenshot of the new section, no options selected:
Screenshot of the new nested filters accordion, no filters entered:
Screenshot of the new nested filters accordion, one filter entered:
Note: lint was complaining about unused variables in a TypeScript function type annotation, so I added
plugin:@typescript-eslint/recommended
to the configuration—this fixed the warning but I needed to turn off a few related rules with existing errors.Related issues
Checklist
improvement
/bug
/ etc)