cli/cmd: add commands for viewing the cache location and clearing it #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjenkins
approved these changes
Jan 3, 2024
cmd/pomerium-cli/cache.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| return os.RemoveAll(filepath.Join(root, "pomerium-cli")) |
There was a problem hiding this comment.
It might be nice to extract this bit of logic to a single shared method. (I see there's already a cachePath() method, but maybe we could rename that one to execCredentialCachePath()?)
(Totally optional; we can always refactor this in a follow-up PR.)
kenjenkins
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Looks good, thanks!
It looks like there's also a cache path constructed in jwtcache.go. I wonder if that one can use this shared cachePath() method too (although that would probably require moving this it to a different package to avoid import issues).
Feel free to submit this PR as is -- we can always refactor the jwt cache path separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add commands:
Related issues
Fixes #279
Checklist
improvement/bug/ etc)