ncrypt: open cert store in readonly mode #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjenkins
force-pushed
the
kenjenkins/cert-store-readonly
branch
from
420f2a3
to
6fa4998
Compare
desimone
approved these changes
Sep 21, 2023
calebdoxsey
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On Windows, trying to open the LocalMachine cert store may require administrator permissions for the default mode (read/write). However, if we include the
CERT_STORE_READONLY_FLAGoption this appears to allow opening the cert store without running as admin.Add a Pomerium copyright line to the modified file, to serve as "prominent notice" that this file has been modified, per clause 4(b) of the Apache License 2.0 (on the recommendation of https://opensource.stackexchange.com/a/13150).
Related issues
Checklist
improvement/bug/ etc)