Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: build for macOS and Windows separately #325

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

kenjenkins
Copy link
Contributor

@kenjenkins kenjenkins commented Sep 5, 2023

Summary

Update the GitHub Actions 'Release' workflow to build for macOS and Windows within separate jobs, so we can perform the macOS builds on a macOS runner and the Windows builds on a Windows runner. This is in preparation for building against OS-specific libraries (with cgo).

Add a separate job at the beginning for setting version flags to be shared across all three build jobs, and a separate job at the end for combining all of the release asset checksums into one file.

Related issues

In preparation for #308.

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@kenjenkins kenjenkins force-pushed the kenjenkins/build-action branch 11 times, most recently from ae30e23 to 310f6b7 Compare September 7, 2023 21:01
@kenjenkins kenjenkins changed the title WIP -- testing pomerium-cli build action release: build macOS and Windows separately Sep 7, 2023
@kenjenkins kenjenkins force-pushed the kenjenkins/build-action branch 2 times, most recently from 3ca7780 to bb9c427 Compare September 7, 2023 21:15
@kenjenkins kenjenkins changed the title release: build macOS and Windows separately release: build for macOS and Windows separately Sep 7, 2023
Update the GitHub Actions 'Release' workflow to build for macOS and
Windows within separate jobs, so we perform the macOS builds on a macOS
runner and the Windows builds on a Windows runner. This is in
preparation for building against OS-specific libraries (with cgo).

Continue to use GoReleaser for the Linux and FreeBSD builds, as well as
the Linux packages and the Docker images.

Add a separate job at the beginning of the workflow for setting version
flags to be shared across all three build jobs, and a separate job at
the end for uploading all of the release asset checksums in one file.
@kenjenkins kenjenkins marked this pull request as ready for review September 7, 2023 22:04
@kenjenkins kenjenkins requested a review from a team as a code owner September 7, 2023 22:04
@kenjenkins kenjenkins merged commit d23ef7e into main Sep 11, 2023
3 checks passed
@kenjenkins kenjenkins deleted the kenjenkins/build-action branch September 11, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants