integrate with system cert store #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjenkins
force-pushed
the
kenjenkins/ecp-trust-store
branch
15 times, most recently
from
c34f484
to
52ae2d1
Compare
kenjenkins
force-pushed
the
kenjenkins/ecp-trust-store
branch
from
98be316
to
66d1230
Compare
Add a new package 'certstore' to provide a common interface for the macOS and Windows platform-specific trust store methods from the vendored 'third_party/ecpsigner' code. Add a new --client-cert-issuer-cn flag to the tcp command using this functionality. Register this flag only when the feature is supported. Update the version output to add a new 'Features:' line to indicate whether pomerium-cli was compiled with support for this feature. Give the macOS integration the feature name 'keychain' and the Windows integration the feature name 'ncrypt'.
kenjenkins
force-pushed
the
kenjenkins/ecp-trust-store
branch
from
66d1230
to
5444ce5
Compare
kenjenkins
changed the title
calebdoxsey
approved these changes
Sep 11, 2023
(I thought this was unused, but I think it's possible to set it via environment variable, so I probably shouldn't remove it.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a new package
certstoreto provide a common interface for the macOS and Windows platform-specific trust store methods from the vendoredthird_party/ecpsignercode.Add a new
--client-cert-issuer-cnflag to the tcp command using this functionality. Register this flag only when the feature is supported.Update the version output to add a new 'Features:' line to indicate whether pomerium-cli was compiled with support for this feature. Give the macOS integration the feature name 'keychain' and the Windows integration the feature name 'ncrypt'.
Related issues
Checklist
improvement/bug/ etc)