Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sentry and signal handlers #29

Merged
merged 1 commit into from
Jan 19, 2022
Merged

add sentry and signal handlers #29

merged 1 commit into from
Jan 19, 2022

Conversation

wasaga
Copy link
Contributor

@wasaga wasaga commented Jan 18, 2022 •
edited
Loading

Summary

  1. Adds optional Sentry handler to API endpoint.
  2. Adds signal handlers to gracefully exit when desktop client UI kills us.
  3. Add gRPC interceptors to log errors to Sentry as its easier then from Electron.

Related issues

https://github.com/pomerium/internal/issues/738

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@wasaga wasaga requested a review from a team as a code owner January 18, 2022 23:39
@wasaga wasaga mentioned this pull request Jan 18, 2022
Merged
6 tasks
@wasaga wasaga merged commit f448fb9 into main Jan 19, 2022
@wasaga wasaga deleted the wasaga/add-sentry branch January 19, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebdoxsey calebdoxsey calebdoxsey approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wasaga @calebdoxsey