close active listener when removing connection #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdoxsey
reviewed
Jan 7, 2022
| if err = s.config.delete(r.GetId()); err != nil { | ||
| ids = append(ids, r.GetId()) | ||
| } | ||
| if _, err = s.disconnectLocked(ids); err != nil { |
There was a problem hiding this comment.
Does disconnect return an error if a connection isn't already connected?
Line 43 in ae250e9
There was a problem hiding this comment.
the only error kind that may be returned is that there's no active listener.
the disconnectLocked would fill in ListenerStatus.LastError field, which we ignore during record deletion.
calebdoxsey
requested changes
Jan 7, 2022
| srv, err := api.NewServer(ctx) | ||
| require.NoError(t, err) | ||
|
|
||
| rec, err := srv.Upsert(ctx, &pb.Record{ |
There was a problem hiding this comment.
Could we add a second record to confirm non-connected listener deletion still works?
calebdoxsey
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If there is an active listener associated with connection record,
previously it would be left active when connection is deleted, blocking the port
until application is restarted.
Related issues
Fixes https://github.com/pomerium/internal/issues/716
Checklist
improvement/bug/ etc)