fix: memory leakage #24

cfanbo · 2022-01-04T11:14:28Z

Summary

FIX memory leakage

calebdoxsey · 2022-01-04T14:46:34Z

I don't think this will work. Reading the docs:

It is not safe to manipulate the
provided backoff policy (notably calling NextBackOff or Reset)
while the ticker is running.

We call .Reset.

time.After can leak, but only if it doesn't fire:

The underlying Timer is not recovered by the garbage collector until the timer fires.

In the case of this code I believe the timer will almost always fire since ctx.Done happens when the program terminates.

Were you seeing a memory leak in practice? Maybe there's some other cause?

fix: memory leakage

415fe4e

cfanbo requested a review from a team as a code owner January 4, 2022 11:14

cfanbo requested a review from calebdoxsey January 4, 2022 11:14

cfanbo closed this Jan 5, 2022