Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deployment: docker image and build commands #10

Merged
merged 7 commits into from
Nov 29, 2021
Merged

deployment: docker image and build commands #10

merged 7 commits into from
Nov 29, 2021

Conversation

travisgroth
Copy link
Contributor

Summary

  • Add release Docker image
  • Add build steps to Makefile
  • Add main branch Docker image

Related issues

n/a

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@travisgroth travisgroth force-pushed the docker_image branch 2 times, most recently from 9e012ad to 42d9eee Compare November 24, 2021 21:31
@travisgroth travisgroth marked this pull request as ready for review November 24, 2021 21:45
@travisgroth travisgroth requested a review from a team as a code owner November 24, 2021 21:45
desimone
desimone approved these changes Nov 24, 2021
View reviewed changes
goreleaser.yaml Outdated Show resolved Hide resolved
Dockerfile.release Outdated Show resolved Hide resolved
desimone
desimone requested changes Nov 29, 2021
View reviewed changes
Makefile

.PHONY: snapshot
snapshot:
APPARITOR_GITHUB_TOKEN=foo goreleaser release --snapshot --rm-dist
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
APPARITOR_GITHUB_TOKEN=foo goreleaser release --snapshot --rm-dist
APPARITOR_GITHUB_TOKEN=foo goreleaser release --snapshot --rm-dist

foo? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it doesn't yell at you for not having a token set.

goreleaser.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Show resolved Hide resolved
@travisgroth
Copy link
Contributor Author

Rebased onto #11

@travisgroth travisgroth merged commit a221078 into main Nov 29, 2021
@travisgroth travisgroth deleted the docker_image branch November 29, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebdoxsey calebdoxsey calebdoxsey approved these changes

@desimone desimone desimone approved these changes

Assignees
No one assigned
Labels
deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@travisgroth @calebdoxsey @desimone