feat: shared packages #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When using a non-custom signer provider (e.g. Browser) and calling eth_signTypedData_v4, we need to pass payload data as a string * chore(provider/js): improve conditional logic in eth_signTypedData --------- Co-authored-by: Pileks <[email protected]>
update dev with latest main
…e-packed # Conflicts: # crates/util/Cargo.toml # crates/util/src/encode.rs # wraps/core/Cargo.toml # wraps/utils/Cargo.toml # wraps/utils/package.json # wraps/utils/src/lib.rs # wraps/utils/src/schema.graphql # wraps/utils/tests/e2e.spec.ts
encode_packed support
Closed
7 tasks
krisbitney
approved these changes
May 3, 2023
dOrgJelli
approved these changes
May 5, 2023
There was a problem hiding this comment.
This all LGTM, aside from:
- fleshing out the README of each wrap
- adding comments to the core wrap's interface (I used ChatGPT for the utils interface, helped speed it up a bit)
- improving typings & variable names on various functions (ex:
toWei(eth: String!)->toWei(eth: BigInt!))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the new structure of the wraps & crates, where two wraps have been created:
Core:
encodeFunctionencodeParamstoEthtoWei*_syncstring has been removed from methods & file, to clean the codebase and make it more maintainableUtils:
Corewere moved hereproviderdependencysolidityPackwas implemented, being compatible withethers.jsimplementation 😄Also updates
ethersversion to2.0.2This is the first iteration of the new structure. This will have two more iterations which will be tracked by these issues (in order):
Also, I wanted to propose that once we merge this, we deploy these new wrappers to the ENS domains:
ethers.wraps.eth:[email protected]ethers.wraps.eth:[email protected]We don't have an easy way to export this two wrappers through the same interface because of this error in the schema compose: polywrap/wrap-cli#1731 - So I think it's okay to start at least using this
coreandutilswraps from ENS. Open to suggestions thoSo we can start migrating uniswap and safe wrappers to this structure and battle test these news wraps 😛