Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unmaintained actions-rs/toolchain by dtolnay/rust-toolchain #473

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Replace unmaintained actions-rs/toolchain by dtolnay/rust-toolchain #473

merged 1 commit into from
Jan 31, 2024

Conversation

striezel
Copy link
Contributor

This replaces the unmaintained actions-rs/toolchain by dtolnay/rust-toolchain.

Basically all of the actions-rs/* actions are unmaintained. See actions-rs/toolchain#216 for more information. Due to their age they generate several warnings in CI runs, for example in https://github.com/polyphony-chat/chorus/actions/runs/7647051419:

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

To get rid of those warnings the occurrences of actions-rs/toolchain are replaced by dtolnay/rust-toolchain.

@kozabrada123 kozabrada123 changed the base branch from main to dev January 31, 2024 21:29
@kozabrada123
Copy link
Member

Looks good, thank you!

@kozabrada123 kozabrada123 merged commit 362dd57 into polyphony-chat:dev Jan 31, 2024
5 checks passed
@striezel striezel deleted the actions-rs-replacement branch February 1, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants