Xbrl context #1
Merged
Xbrl context #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change focus to regular XBRL * add review gh action workflow * add important steps to workflow * dont use golang docker image
calebcase
approved these changes
Jun 8, 2021
|
|
||
| // Identifier specifies a scheme for identifying business entities and an identifier that follows the scheme. | ||
| // https://www.xbrl.org/Specification/XBRL-2.1/REC-2003-12-31/XBRL-2.1-REC-2003-12-31+corrected-errata-2013-02-20.html#_4.7.3.1 | ||
| // For Example: |
There was a problem hiding this comment.
<3 including examples of the data that might be parsed
| Instant *string `xml:"instant"` | ||
|
|
||
| // Forever is non-nil if Period.Type() returns Forever. | ||
| // Note ideally this would be a bool, but the XML Unmarshaller doesn't support |
There was a problem hiding this comment.
Should we make a custom unmarshal for it?
There was a problem hiding this comment.
I don't think it's really necessary. Type() returning Forever is already a clean way to determine if the period represents 'forever', so you wouldn't really have to interact with this property directly as a user.
I might come back to this later once I'm more experienced with custom unmarshallers though
This might be valuable if/when we come back and add support for Context |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our purposes, XBRL consists of contexts, facts, and units. This is part one: the contexts