Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix api.derive.accounts.{info && identity} #5885

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented May 17, 2024

closes: #5883

Fixes

api.derive.accounts.identity
api.derive.accounts.info

This fix ensure the derive for identity also takes into the account the new logic in the Peoples Chain.

The identity type IdentitiyInfo has 4 fields that have been added or changed:

---- additional
---- riot
+++ matrix
+++ github
+++ discord

This ensure it has support while also supporting the legacy structure.

Maybe I should add the new as PeopleIdentityInfo type to the augmented type generation?
rel: #5884

@TarikGul TarikGul changed the title Fix api.derive.accounts.identity and all residual derives Fix api.derive.accounts.{info && identity} May 17, 2024
@TarikGul TarikGul added the -auto label May 17, 2024
@polkadot-js-bot polkadot-js-bot merged commit f9c5820 into master May 17, 2024
6 checks passed
@polkadot-js-bot polkadot-js-bot deleted the tg-fix-derive-dent branch May 17, 2024 20:22
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api.derive.accounts.identity broken ? | People Chain
2 participants