-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CheckMetadataHash
signedExtension
support
#5882
Conversation
}, | ||
|
||
// This is the CheckMetadataHash SignedExtension type. | ||
MetadataHash: 'Option<Vec<u8>>' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the mode
is an enum/u8. And the additional signed is a special type that encodes to nothing if mode == 0
, otherwise it only passes a [u8; 32]
.
@@ -5,6 +5,13 @@ import type { ExtDef, ExtInfo } from './types.js'; | |||
|
|||
import { emptyCheck } from './emptyCheck.js'; | |||
|
|||
const CheckMetadataHash: ExtInfo = { | |||
extrinsic: { | |||
metadataHash: 'MetadataHash' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
metadataHash: 'MetadataHash' | |
metadataHash: 'u8' |
@bee344 when are you planning to tackle this? I will also need this for my pr to pass CI :D |
@bkchr I'll do it today |
heads up @bee344 some last minute changes to the signed extension, the signed data is now an |
CheckMetadataHash
signedExtension
support
@bee344 Small nits. We should also add a test for in |
Update:
Using |
@bkchr Yup, its scheduled to be released today :) |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
closes: #5881
rel: paritytech/polkadot-sdk#4274
Update:
Tested
Using
Txwrapper-core
to create thePayloads
and to create aSubmittableExtrinsic
and aSignedExtrinsic
with it, in order to confirm this addition didn't break any historic compatibility.