Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Porting a backtrader strategy notebook #115

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

jacopomaroli
Copy link

as per #113 :)

@polakowo polakowo merged commit 44968ac into polakowo:master Mar 25, 2021
@polakowo
Copy link
Owner

Merging, and congrats on your first contribution!

@polakowo
Copy link
Owner

polakowo commented Mar 25, 2021

I just noticed that you're still not shown as a contributor. Strangely, under the commit b63def5 your photo and name are shown, but not link to your Github profile. Can you resolve this? If not, you can make another PR with any cosmetic change to vectorbt using your current Github account and I will approve it to add your profile as a contributor.

@jacopomaroli
Copy link
Author

thank you for noticing it :) I Indeed had an email address in my ssh config which was not present in my github account.
as per instructions here https://docs.github.com/en/github/setting-up-and-managing-your-github-profile/why-are-my-contributions-not-showing-up-on-my-profile adding a .patch after the commit URL shows such address.
I added it to my profile and github should rebuild my contribs graph within 24h!

@polakowo
Copy link
Owner

If it still won’t show under contributors on the front page of vectorbt, just submit a PR with a slight change to readme/notebook, like adding an extra space somewhere :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants