Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Use branchless uleb128 decoding for parquet #16352

Merged
merged 1 commit into from
May 21, 2024
Merged

perf: Use branchless uleb128 decoding for parquet #16352

merged 1 commit into from
May 21, 2024

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.36%. Comparing base (1cdab6f) to head (e3f5dc3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16352      +/-   ##
==========================================
- Coverage   81.37%   81.36%   -0.02%     
==========================================
  Files        1405     1405              
  Lines      183738   183745       +7     
  Branches     2957     2957              
==========================================
- Hits       149525   149511      -14     
- Misses      33700    33721      +21     
  Partials      513      513              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 21, 2024

CodSpeed Performance Report

Merging #16352 will degrade performances by 17.82%

Comparing parquet (e3f5dc3) with main (1cdab6f)

Summary

❌ 1 regressions
✅ 36 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main parquet Change
test_groupby_h2oai_q5 8.4 ms 10.2 ms -17.82%

@ritchie46 ritchie46 merged commit 2d03c39 into main May 21, 2024
22 checks passed
@ritchie46 ritchie46 deleted the parquet branch May 21, 2024 09:21
@c-peters c-peters added the accepted Ready for implementation label May 27, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants