perf: use is_sorted in ewm_mean_by, deprecate check_sorted #16335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
performance
MarcoGorelli
force-pushed
the
use-is-sorted-in-ewm-mean-by
branch
2 times, most recently
from
2cc570c
to
e6ed310
Compare
MarcoGorelli
force-pushed
the
use-is-sorted-in-ewm-mean-by
branch
from
e6ed310
to
5883c43
Compare
MarcoGorelli
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
reswqa and
orlp
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16335 +/- ##
=======================================
Coverage 81.36% 81.37%
=======================================
Files 1403 1403
Lines 183739 183760 +21
Branches 2954 2955 +1
=======================================
+ Hits 149507 149531 +24
+ Misses 33721 33718 -3
Partials 511 511 ☔ View full report in Codecov by Sentry. |
Wouittone
pushed a commit
to Wouittone/polars
that referenced
this pull request
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
is_sortedhas been improved, then I think it makes sense to just removecheck_sorted- not sure users should be setting it really as it could lead to incorrect results if misused