chore: simplify interpolate code, add test for rolling_*_by with nulls #16334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16334 +/- ##
=======================================
Coverage 81.36% 81.37%
=======================================
Files 1403 1403
Lines 183739 183729 -10
Branches 2954 2954
=======================================
+ Hits 149507 149509 +2
+ Misses 33721 33709 -12
Partials 511 511 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
May 20, 2024
Wouittone
pushed a commit
to Wouittone/polars
that referenced
this pull request
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
applying some suggestions from #16313 to some 'old' code
Removing so many levels of indentation was quite pleasing 😋