Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Move expression expansion to conversion module #16331

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels May 20, 2024
Copy link

codspeed-hq bot commented May 20, 2024

CodSpeed Performance Report

Merging #16331 will improve performances by 15.12%

Comparing expand (d6adfd6) with main (f5c32f2)

Summary

⚡ 1 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmark main expand Change
test_groupby_h2oai_q4 9.8 ms 8.5 ms +15.12%

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.35%. Comparing base (f5c32f2) to head (d6adfd6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16331   +/-   ##
=======================================
  Coverage   81.35%   81.35%           
=======================================
  Files        1403     1403           
  Lines      183707   183707           
  Branches     2954     2954           
=======================================
+ Hits       149460   149461    +1     
+ Misses      33736    33735    -1     
  Partials      511      511           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit b359a23 into main May 20, 2024
22 checks passed
@ritchie46 ritchie46 deleted the expand branch May 20, 2024 09:34
@c-peters c-peters added the accepted Ready for implementation label May 21, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants