Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Raise when joining on the same keys twice #16329

Merged
merged 3 commits into from
May 20, 2024
Merged

feat: Raise when joining on the same keys twice #16329

merged 3 commits into from
May 20, 2024

Conversation

ritchie46
Copy link
Member

fixes #16289

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels May 20, 2024
@ritchie46 ritchie46 merged commit f5c32f2 into main May 20, 2024
24 checks passed
@ritchie46 ritchie46 deleted the raise branch May 20, 2024 08:28
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 20, 2024

CodSpeed Performance Report

Merging #16329 will improve performances by 17.69%

Comparing raise (21dd6c9) with main (1b58f78)

Summary

⚡ 1 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmark main raise Change
⚡ test_tpch_q15 8.8 ms 7.5 ms +17.69%

@wence- wence- mentioned this pull request May 28, 2024
Closed
2 tasks
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
@ritchie46 @Wouittone
feat: Raise when joining on the same keys twice (pola-rs#16329)
ec719b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego Awaiting requested review from stinodego stinodego is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
1 participant
@ritchie46