Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't stackoverflow on all/any horizontal #16287

Merged
merged 2 commits into from
May 17, 2024
Merged

fix: Don't stackoverflow on all/any horizontal #16287

merged 2 commits into from
May 17, 2024

Conversation

ritchie46
Copy link
Member

fixes #16270

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 5.55556% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 80.79%. Comparing base (bbe73bd) to head (f885a3c).

Files Patch % Lines
...rates/polars-plan/src/dsl/function_expr/boolean.rs 0.00% 34 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16287      +/-   ##
==========================================
- Coverage   80.81%   80.79%   -0.02%     
==========================================
  Files        1393     1393              
  Lines      179337   179370      +33     
  Branches     2921     2921              
==========================================
- Hits       144923   144917       -6     
- Misses      33911    33950      +39     
  Partials      503      503              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit c884d5d into main May 17, 2024
20 of 21 checks passed
@ritchie46 ritchie46 deleted the reduce branch May 17, 2024 10:02
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack Overflow (?) crash when using all_horizontal
1 participant