perf: use zeroed vec in ewm_mean_by for sorted fastpath #16265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
performance
MarcoGorelli
force-pushed
the
zeroed-vec-ewm
branch
from
e8b96a8
to
8e7120d
Compare
MarcoGorelli
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16265 +/- ##
=======================================
Coverage 80.86% 80.87%
=======================================
Files 1393 1393
Lines 179161 179179 +18
Branches 2913 2913
=======================================
+ Hits 144887 144914 +27
+ Misses 33771 33762 -9
Partials 503 503 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
May 16, 2024
Wouittone
pushed a commit
to Wouittone/polars
that referenced
this pull request
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.