Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Show warning if expressions are very deep #16233

Merged
merged 1 commit into from
May 15, 2024
Merged

feat: Show warning if expressions are very deep #16233

merged 1 commit into from
May 15, 2024

Conversation

ritchie46
Copy link
Member

closes #16225

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels May 15, 2024
@codecov Codecov
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 80.86%. Comparing base (15f6b36) to head (ead377d).

Files Patch % Lines
...ates/polars-lazy/src/physical_plan/planner/expr.rs 93.25% 6 Missing ⚠️
py-polars/polars/config.py 28.57% 5 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #16233   +/-   ##
=======================================
  Coverage   80.85%   80.86%           
=======================================
  Files        1394     1394           
  Lines      179955   180030   +75     
  Branches     2909     2911    +2     
=======================================
+ Hits       145508   145579   +71     
- Misses      33942    33946    +4     
  Partials      505      505

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 6716651 into main May 15, 2024
28 checks passed
@ritchie46 ritchie46 deleted the limit branch May 15, 2024 08:22
MarcoGorelli pushed a commit to MarcoGorelli/polars that referenced this pull request May 15, 2024
@ritchie46 @MarcoGorelli
feat: Show warning if expressions are very deep (pola-rs#16233)
bec833d
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
@ritchie46 @Wouittone
feat: Show warning if expressions are very deep (pola-rs#16233)
fb58bd4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego Awaiting requested review from stinodego stinodego is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stack overflow in physical executor with very deep expression trees
1 participant
@ritchie46