-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Update Rust nightly toolchain version #16222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
714383c
to
1ca490b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16222 +/- ##
==========================================
- Coverage 80.93% 80.86% -0.08%
==========================================
Files 1394 1395 +1
Lines 179564 179956 +392
Branches 2908 2909 +1
==========================================
+ Hits 145329 145515 +186
- Misses 33730 33936 +206
Partials 505 505 ☔ View full report in Codecov by Sentry. |
1ca490b
to
cde5618
Compare
MarcoGorelli
pushed a commit
to MarcoGorelli/polars
that referenced
this pull request
May 15, 2024
Wouittone
pushed a commit
to Wouittone/polars
that referenced
this pull request
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New lint catches nonexistent feature flags - which effectively leads to dead code in many cases. The fix is to either add the feature flag or remove the dead code.
There was quite a lot to fix. A few notable things:
polars-arrow/src/util/bench_util.rs
module, which is unused and hidden behind a nonexistent feature flag.use_mimalloc
anddefault_allocator
for the PyO3 bindings.