Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update Rust nightly toolchain version #16222

Merged
merged 32 commits into from
May 15, 2024
Merged

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented May 14, 2024

New lint catches nonexistent feature flags - which effectively leads to dead code in many cases. The fix is to either add the feature flag or remove the dead code.

There was quite a lot to fix. A few notable things:

  • Removed the polars-arrow/src/util/bench_util.rs module, which is unused and hidden behind a nonexistent feature flag.
  • Removed two Parquet test modules with test that weren't running and referenced non-existing code.
  • Added feature flags for use_mimalloc and default_allocator for the PyO3 bindings.
  • Some PyO3 code was hidden behind a non-existing flag, it had to be updated to the new bound API.

@stinodego stinodego changed the title Update rust nightly build: Update Rust nightly toolchain version May 14, 2024
@github-actions github-actions bot added build Changes that affect the build system or external dependencies python Related to Python Polars rust Related to Rust Polars labels May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 80.86%. Comparing base (004efbe) to head (cde5618).
Report is 2 commits behind head on main.

Files Patch % Lines
py-polars/src/map/series.rs 0.00% 13 Missing ⚠️
crates/polars-arrow/src/datatypes/mod.rs 0.00% 1 Missing ⚠️
crates/polars-arrow/src/datatypes/physical_type.rs 0.00% 1 Missing ⚠️
crates/polars-arrow/src/types/mod.rs 0.00% 1 Missing ⚠️
crates/polars-json/src/json/write/serialize.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16222      +/-   ##
==========================================
- Coverage   80.93%   80.86%   -0.08%     
==========================================
  Files        1394     1395       +1     
  Lines      179564   179956     +392     
  Branches     2908     2909       +1     
==========================================
+ Hits       145329   145515     +186     
- Misses      33730    33936     +206     
  Partials      505      505              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as ready for review May 14, 2024 22:22
@ritchie46 ritchie46 merged commit 15f6b36 into main May 15, 2024
27 checks passed
@ritchie46 ritchie46 deleted the update-rust-nightly branch May 15, 2024 04:54
MarcoGorelli pushed a commit to MarcoGorelli/polars that referenced this pull request May 15, 2024
@c-peters c-peters added the accepted Ready for implementation label May 21, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation build Changes that affect the build system or external dependencies python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants