Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix streaming glob slice #16174

Merged
merged 3 commits into from
May 12, 2024
Merged

fix: Fix streaming glob slice #16174

merged 3 commits into from
May 12, 2024

Conversation

ritchie46
Copy link
Member

fixes #16163

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels May 12, 2024
Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 80.99%. Comparing base (492c9d9) to head (3a7b532).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/polars-utils/src/arena.rs 0.00% 4 Missing ⚠️
...s/polars-io/src/csv/read/read_impl/batched_read.rs 92.30% 1 Missing ⚠️
.../src/physical_plan/streaming/construct_pipeline.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16174      +/-   ##
==========================================
+ Coverage   80.98%   80.99%   +0.01%     
==========================================
  Files        1387     1387              
  Lines      178857   178832      -25     
  Branches     2877     2877              
==========================================
+ Hits       144842   144845       +3     
+ Misses      33521    33495      -26     
+ Partials      494      492       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 3892c75 into main May 12, 2024
25 of 26 checks passed
@ritchie46 ritchie46 deleted the streaming branch May 12, 2024 12:45
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PanicException when slicing a LazyFrame streaming from globbed CSV
1 participant