Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't override CSV reader encoding with lossy UTF-8 #16151

Merged
merged 2 commits into from
May 10, 2024
Merged

fix: Don't override CSV reader encoding with lossy UTF-8 #16151

merged 2 commits into from
May 10, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented May 10, 2024 •
edited
Loading

@github-actions github-actions bot added the internal An internal refactor or improvement label May 10, 2024
@codecov Codecov
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.95%. Comparing base (b2291b9) to head (4b7a1f6).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16151      +/-   ##
==========================================
- Coverage   80.96%   80.95%   -0.01%     
==========================================
  Files        1386     1386              
  Lines      178492   178478      -14     
  Branches     2882     2882              
==========================================
- Hits       144508   144494      -14     
+ Misses      33492    33491       -1     
- Partials      492      493       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

ritchie46 commented May 10, 2024 •
edited
Loading

Wow, that commit is ancient. Pretty sure it was rubbish too.

@nameexhaustion nameexhaustion changed the title test removing LossyUtf8 override fix: Don't override CSV reader encoding with utf8-lossy May 10, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review May 10, 2024 11:20
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels May 10, 2024
@nameexhaustion nameexhaustion changed the title fix: Don't override CSV reader encoding with utf8-lossy fix: Don't override CSV reader encoding with lossy UTF-8 May 10, 2024
@ritchie46 ritchie46 merged commit ebeddf9 into pola-rs:main May 10, 2024
24 checks passed
@nameexhaustion nameexhaustion deleted the csv-lossy branch May 10, 2024 11:21
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
@nameexhaustion @Wouittone
fix: Don't override CSV reader encoding with lossy UTF-8 (pola-rs#16151)
677e8b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@stinodego stinodego Awaiting requested review from stinodego

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees
No one assigned
Labels
fix Bug fix internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nameexhaustion @ritchie46