Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(rust): Solve inconsistency between code and comment #16135

Merged
merged 2 commits into from
May 9, 2024

Conversation

YichiZhang0613
Copy link
Contributor

This PR fixed some inconsistency between code and comment in #15968 .

Closes #15968

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.95%. Comparing base (16245cd) to head (214e7f5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16135      +/-   ##
==========================================
- Coverage   80.96%   80.95%   -0.01%     
==========================================
  Files        1386     1386              
  Lines      178440   178438       -2     
  Branches     2883     2882       -1     
==========================================
- Hits       144469   144452      -17     
- Misses      33478    33492      +14     
- Partials      493      494       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 9, 2024

CodSpeed Performance Report

Merging #16135 will improve performances by 26.38%

Comparing YichiZhang0613:fix_inconsistency (214e7f5) with main (475bac5)

Summary

⚡ 1 improvements
✅ 34 untouched benchmarks

Benchmarks breakdown

Benchmark main YichiZhang0613:fix_inconsistency Change
test_filter2 2.8 ms 2.2 ms +26.38%

@YichiZhang0613 YichiZhang0613 changed the title fix(rust): Solve inconsistency bewteen code and commen fix(rust): Solve inconsistency bewteen code and comment May 9, 2024
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@stinodego stinodego changed the title fix(rust): Solve inconsistency bewteen code and comment docs(rust): Solve inconsistency between code and comment May 9, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 9, 2024
@stinodego stinodego removed the fix Bug fix label May 9, 2024
@stinodego stinodego merged commit c4e8678 into pola-rs:main May 9, 2024
24 checks passed
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency between code and comment
2 participants