fix(rust): Add missing allow macros for windows #16130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was unable to run `make pre-commit`: `error: could not compile `py-polars` (lib) due to 3 previous errors` This simply adds the three missing allows.
dangotbanned
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16130 +/- ##
=======================================
Coverage 80.95% 80.96%
=======================================
Files 1386 1386
Lines 178434 178441 +7
Branches 2878 2883 +5
=======================================
+ Hits 144455 144466 +11
+ Misses 33487 33482 -5
- Partials 492 493 +1 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
May 9, 2024
|
This should really be feature gated correctly instead of be ignored. |
Wouittone
pushed a commit
to Wouittone/polars
that referenced
this pull request
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was unable to run
make pre-commit:This simply adds the three missing allows.
Fixes #16129