Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support non-coalescing joins in default engine #16036

Merged
merged 1 commit into from
May 3, 2024
Merged

feat: Support non-coalescing joins in default engine #16036

merged 1 commit into from
May 3, 2024

Conversation

ritchie46
Copy link
Member

closes #14925

Left join still coalesces by default. Would need a breaking release to change the default.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels May 3, 2024
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.92%. Comparing base (a3dedb1) to head (a181627).
Report is 4 commits behind head on main.

Files Patch % Lines
.../polars-lazy/src/physical_plan/streaming/checks.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16036   +/-   ##
=======================================
  Coverage   80.92%   80.92%           
=======================================
  Files        1385     1385           
  Lines      178242   178233    -9     
  Branches     3050     3050           
=======================================
- Hits       144234   144228    -6     
+ Misses      33520    33516    -4     
- Partials      488      489    +1     
Flag Coverage Δ
python 74.40% <88.23%> (+<0.01%) ⬆️
rust 78.13% <94.11%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 3, 2024

CodSpeed Performance Report

Merging #16036 will improve performances by 33.88%

Comparing join (a181627) with main (5da378f)

Summary

⚡ 1 improvements
✅ 34 untouched benchmarks

Benchmarks breakdown

Benchmark main join Change
test_filter2 2.8 ms 2.1 ms +33.88%

@ritchie46 ritchie46 merged commit dc45fc0 into main May 3, 2024
27 checks passed
@ritchie46 ritchie46 deleted the join branch May 3, 2024 14:09
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add coalesce argument to join
1 participant