Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Convert concat during IR conversion #16016

Merged
merged 2 commits into from
May 2, 2024
Merged

feat: Convert concat during IR conversion #16016

merged 2 commits into from
May 2, 2024

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented May 2, 2024

Still a few to go.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 89.83051% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 80.91%. Comparing base (f03e7e0) to head (2c78e47).

Files Patch % Lines
crates/polars-plan/src/logical_plan/tree_format.rs 0.00% 5 Missing ⚠️
...lars-plan/src/logical_plan/conversion/dsl_to_ir.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16016      +/-   ##
==========================================
- Coverage   80.91%   80.91%   -0.01%     
==========================================
  Files        1384     1385       +1     
  Lines      178226   178225       -1     
  Branches     3050     3050              
==========================================
- Hits       144218   144210       -8     
- Misses      33519    33527       +8     
+ Partials      489      488       -1     
Flag Coverage Δ
python 74.39% <89.83%> (+<0.01%) ⬆️
rust 78.13% <89.83%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit b7b3da6 into main May 2, 2024
22 checks passed
@ritchie46 ritchie46 deleted the schema branch May 2, 2024 13:19
AlexanderNenninger pushed a commit to AlexanderNenninger/polars that referenced this pull request May 3, 2024
@c-peters c-peters added the accepted Ready for implementation label May 6, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants