fix: Fix PartialEq for DataType::Unknown #15992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
requested review from
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
ritchie46
commented
May 1, 2024
| @@ -240,15 +240,7 @@ pub(super) fn process_binary( | |||
| right: node_right, | |||
| })); | |||
| }, | |||
| (Unknown(lhs), Unknown(rhs)) if lhs == rhs => { | |||
ritchie46
commented
May 1, 2024
| @@ -472,14 +472,14 @@ def test_replace_fast_path_many_to_one() -> None: | |||
| def test_replace_fast_path_many_to_one_default() -> None: | |||
| lf = pl.LazyFrame({"a": [1, 2, 2, 3]}) | |||
| result = lf.select(pl.col("a").replace([2, 3], 100, default=-1)) | |||
| expected = pl.LazyFrame({"a": [-1, 100, 100, 100]}, schema={"a": pl.Int32}) | |||
| expected = pl.LazyFrame({"a": [-1, 100, 100, 100]}, schema={"a": pl.Int64}) | |||
There was a problem hiding this comment.
This was wrong as the original dtype was i64.
2 tasks
Wouittone
pushed a commit
to Wouittone/polars
that referenced
this pull request
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.