fix(rust): typo in add_half_life takes ln(negative) #15932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jr200
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
|
Thanks - your fix looks correct, I'm just confused by this function. It's not used anywhere? It's not tested? Maybe it should just be removed? |
Yes I noticed that - its also under |
stinodego
approved these changes
Apr 28, 2024
I believe it's part of the Rust public API. We might remove it at some point, but until we do, it better be correct. |
Wouittone
pushed a commit
to Wouittone/polars
that referenced
this pull request
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated fn body to match documented formula.