Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): More polars-io cleanup #15885

Merged
merged 16 commits into from
Apr 25, 2024
Merged

refactor(rust): More polars-io cleanup #15885

merged 16 commits into from
Apr 25, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Apr 25, 2024

Changes

  • Moved some tests to the integration test folder
  • Clean up some imports/exports

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Apr 25, 2024
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 84.87805% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 81.25%. Comparing base (8ea75df) to head (0db1ff0).
Report is 8 commits behind head on main.

Files Patch % Lines
crates/polars-io/src/shared.rs 68.42% 18 Missing ⚠️
crates/polars-io/src/partition.rs 0.00% 11 Missing ⚠️
crates/polars-io/src/ipc/mmap.rs 96.42% 1 Missing ⚠️
crates/polars-io/src/utils.rs 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15885      +/-   ##
==========================================
- Coverage   81.34%   81.25%   -0.09%     
==========================================
  Files        1384     1381       -3     
  Lines      176907   176716     -191     
  Branches     3033     3033              
==========================================
- Hits       143897   143591     -306     
- Misses      32525    32639     +114     
- Partials      485      486       +1     
Flag Coverage Δ
python 74.70% <78.94%> (-0.04%) ⬇️
rust 78.38% <84.87%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as ready for review April 25, 2024 12:00
@stinodego stinodego merged commit 7f4bf77 into main Apr 25, 2024
21 checks passed
@stinodego stinodego deleted the io-refactor branch April 25, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant