Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Reorganize polars_io::parquet module #15860

Merged
merged 18 commits into from
Apr 24, 2024
Merged

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Apr 24, 2024

Similar to #15831

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 89.35484% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 81.37%. Comparing base (ba85175) to head (1ded963).
Report is 6 commits behind head on main.

Files Patch % Lines
crates/polars-io/src/parquet/write/options.rs 50.00% 17 Missing ⚠️
...ates/polars-io/src/parquet/write/batched_writer.rs 91.76% 14 Missing ⚠️
crates/polars-io/src/parquet/read/options.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15860      +/-   ##
==========================================
+ Coverage   80.39%   81.37%   +0.98%     
==========================================
  Files        1263     1382     +119     
  Lines      165368   176827   +11459     
  Branches        0     3032    +3032     
==========================================
+ Hits       132941   143890   +10949     
- Misses      32427    32449      +22     
- Partials        0      488     +488     
Flag Coverage Δ
python 74.76% <89.35%> (?)
rust 78.50% <89.35%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as ready for review April 24, 2024 13:56
@ritchie46 ritchie46 merged commit 1a4327d into main Apr 24, 2024
21 checks passed
@ritchie46 ritchie46 deleted the io-refactor2 branch April 24, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants