Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Move IO-related options structs to polars-io #15806

Merged
merged 7 commits into from
Apr 21, 2024
Merged

Conversation

stinodego
Copy link
Member

No description provided.

@github-actions github-actions bot added breaking rust Change that breaks backwards compatibility for the Rust crate internal An internal refactor or improvement rust Related to Rust Polars labels Apr 20, 2024
Copy link

codecov bot commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.40%. Comparing base (0c37ead) to head (98a7eb1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15806   +/-   ##
=======================================
  Coverage   80.39%   80.40%           
=======================================
  Files        1264     1264           
  Lines      165421   165423    +2     
=======================================
+ Hits       132994   133002    +8     
+ Misses      32427    32421    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as ready for review April 20, 2024 18:54
Copy link

codspeed-hq bot commented Apr 20, 2024

CodSpeed Performance Report

Merging #15806 will not alter performance

Comparing io-options (98a7eb1) with main (937fd46)

Summary

✅ 22 untouched benchmarks

@ritchie46 ritchie46 merged commit d58b912 into main Apr 21, 2024
22 checks passed
@ritchie46 ritchie46 deleted the io-options branch April 21, 2024 08:51
@ritchie46
Copy link
Member

Is it breaking Rust though? They should still be importable via polars right? As in the structs don't change and they are still available via public imports. (polars-plan isn't meant as public).

@stinodego stinodego removed the breaking rust Change that breaks backwards compatibility for the Rust crate label Apr 21, 2024
@stinodego stinodego changed the title refactor(rust!): Move IO-related options structs to polars-io refactor(rust): Move IO-related options structs to polars-io Apr 21, 2024
@stinodego
Copy link
Member Author

If we only consider the polars crate public, this isn't breaking. I removed the tag!

@c-peters c-peters added the accepted Ready for implementation label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants