Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Preserve lexical ordering on concat #15753

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

c-peters
Copy link
Collaborator

fix #15708

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Apr 18, 2024
Copy link

codspeed-hq bot commented Apr 18, 2024

CodSpeed Performance Report

Merging #15753 will not alter performance

Comparing c-peters:cat_sort_order (f1d435b) with main (96e1f01)

Summary

✅ 22 untouched benchmarks

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.36%. Comparing base (96e1f01) to head (f1d435b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15753   +/-   ##
=======================================
  Coverage   81.35%   81.36%           
=======================================
  Files        1379     1379           
  Lines      176603   176611    +8     
  Branches     2544     2544           
=======================================
+ Hits       143677   143699   +22     
+ Misses      32443    32429   -14     
  Partials      483      483           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego
Copy link
Member

Looks good, thanks @c-peters !

@ritchie46 ritchie46 merged commit 7fb5db0 into pola-rs:main Apr 19, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Categorical ordering (lexical vs physical) reset by concatenation
3 participants