Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: raise if index count like 2i is used when performing rolling, group_by_dynamic, upsample, or other temporal operatios #15751

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

MarcoGorelli
Copy link
Collaborator

closes #15749

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Apr 18, 2024
Comment on lines -479 to -488
@pytest.mark.parametrize(
("every", "match"),
[
("-1i", r"'every' argument must be positive"),
(
"2h",
r"you cannot combine time durations like '2h' with integer durations like '3i'",
),
],
)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two errors are completely different, I've moved the second one out into a separate test below

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.35%. Comparing base (0c2783a) to head (6173e48).

❗ Current head 6173e48 differs from pull request most recent head fff4334. Consider uploading reports for the commit fff4334 to get more accurate results

Files Patch % Lines
crates/polars-time/src/windows/duration.rs 91.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15751   +/-   ##
=======================================
  Coverage   81.35%   81.35%           
=======================================
  Files        1379     1379           
  Lines      176619   176613    -6     
  Branches     2544     2544           
=======================================
+ Hits       143686   143688    +2     
+ Misses      32449    32442    -7     
+ Partials      484      483    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Apr 18, 2024

CodSpeed Performance Report

Merging #15751 will not alter performance

Comparing MarcoGorelli:duration-validation (fff4334) with main (0c2783a)

Summary

✅ 22 untouched benchmarks

…oup_by_dynamic, upsample, or other temporal operation on datetime column
@MarcoGorelli MarcoGorelli marked this pull request as ready for review April 19, 2024 08:28
@ritchie46 ritchie46 merged commit d11da5e into pola-rs:main Apr 19, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using parsed integer in rolling when time column is Datetime should raise
2 participants