fix: Remove incorrect unsafe pointer cast for int -> enum #15740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
reswqa
commented
Apr 18, 2024
| @@ -136,9 +136,6 @@ where | |||
| polars_bail!(OutOfBounds: "index {} is bigger than the number of categories {}",m,categories.len()); | |||
| } | |||
| } | |||
| // SAFETY: | |||
| // we are guarded by the type system | |||
| let ca = unsafe { &*(self as *const ChunkedArray<T> as *const UInt32Chunked) }; | |||
There was a problem hiding this comment.
Self is not always UInt32Chunked, this line is really evil and useless indeed. 😨
There was a problem hiding this comment.
Yes, L114 makes this line unsound. 🤔
reswqa
requested review from
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli and
orlp
as code owners
CodSpeed Performance ReportMerging #15740 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #15738.