Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(python,rust): fix inconsistent decimal formatting #15457

Merged
merged 2 commits into from
Apr 26, 2024
Merged

fix(python,rust): fix inconsistent decimal formatting #15457

merged 2 commits into from
Apr 26, 2024

Conversation

Julian-J-S
Copy link
Contributor

fix #13985

currently decimal values are formatted without any decimal values if value is an integer.

Decimal[scale=2]

  • 1.23 -> 1.23
  • 1.2 -> 1.20
  • 1 -> 1 💥

This is inconsistent and different than in all other systems like databases.

new:

  • 1 -> 1.00 ✅

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Apr 3, 2024
ritchie46
ritchie46 approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JulianCologne

@ritchie46 ritchie46 merged commit 5253e46 into pola-rs:main Apr 26, 2024
23 checks passed
@Julian-J-S Julian-J-S deleted the fix-decimal-fmt-for-integers branch April 26, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@stinodego stinodego Awaiting requested review from stinodego stinodego is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decimals not formatted correctly in ouput (decimal places missing)
2 participants
@Julian-J-S @ritchie46