ACR125 has the same LED/Buzzer support as ACR122 :) #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JohnMcLear, Thank you for your PR. 👍 I cannot find any ACR125 (Didn't you mean ACR1252U?). Could you please send link to the specific ACS product / docs page (so we can add it as comment into the code)? Then, I'll merge the PR. BTW: It would be much cleaner to create a new subclass and extract the common functionality (e.g. the buzzer command) into some shared helper function But for now, I am more than okay with your patch. 🙂 |
|
Yes ACR1252U https://www.acs.com.hk/en/products/342/acr1252u-usb-nfc-reader-iii-nfc-forum-certified-reader/ Sorry RE code quality, noted RE future approaches, and yeah, agreed. |
|
@JohnMcLear Thanks. 👍 Shipped in v0.8.1. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.