-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💡 [Feature]: Add more settings for the extension #200
Labels
⭐ enhancement
New feature or request
💪 good first issue
Good for newcomers
👨💻work in progress
I am working on it
Milestone
Comments
Adam-it
added
👨💻work in progress
I am working on it
and removed
🙏 help wanted
Open for contributors
labels
Jul 28, 2024
Working on it! 😸 |
Adam-it
added a commit
that referenced
this issue
Aug 5, 2024
…sions. Closes: #200 (#281) ## 🎯 Aim This PR implements the required settings of issue [#200](#200). ## 📷 Result ![image](https://github.com/user-attachments/assets/ec83766a-d8c6-45f9-ad49-29fb53b82703) ## ✅ What was done Added two settings for the extension: - showServiceIncidentList - showTenantWideExtensions Updated the `TerminalCommandExecuter` extracting the `getExtensionSettings` method and creating a dedicated util file. Updated the `CommandPanel` to keep into account the new settings when loading and showing data. ## 🔗 Related issue Closes: #200 --------- Co-authored-by: Saurabh Tripathi <[email protected]> Co-authored-by: Adam Wójcik <[email protected]> Co-authored-by: Luccas Castro <[email protected]> Co-authored-by: Adam Wójcik <[email protected]>
The related PR was merged 😍. |
Adam-it
added a commit
that referenced
this issue
Aug 6, 2024
…sions. Closes: #200 (#281) ## 🎯 Aim This PR implements the required settings of issue [#200](#200). ## 📷 Result ![image](https://github.com/user-attachments/assets/ec83766a-d8c6-45f9-ad49-29fb53b82703) ## ✅ What was done Added two settings for the extension: - showServiceIncidentList - showTenantWideExtensions Updated the `TerminalCommandExecuter` extracting the `getExtensionSettings` method and creating a dedicated util file. Updated the `CommandPanel` to keep into account the new settings when loading and showing data. ## 🔗 Related issue Closes: #200 --------- Co-authored-by: Saurabh Tripathi <[email protected]> Co-authored-by: Adam Wójcik <[email protected]> Co-authored-by: Luccas Castro <[email protected]> Co-authored-by: Adam Wójcik <[email protected]>
Adam-it
added a commit
that referenced
this issue
Sep 8, 2024
…sions. Closes: #200 (#281) ## 🎯 Aim This PR implements the required settings of issue [#200](#200). ## 📷 Result ![image](https://github.com/user-attachments/assets/ec83766a-d8c6-45f9-ad49-29fb53b82703) ## ✅ What was done Added two settings for the extension: - showServiceIncidentList - showTenantWideExtensions Updated the `TerminalCommandExecuter` extracting the `getExtensionSettings` method and creating a dedicated util file. Updated the `CommandPanel` to keep into account the new settings when loading and showing data. ## 🔗 Related issue Closes: #200 --------- Co-authored-by: Saurabh Tripathi <[email protected]> Co-authored-by: Adam Wójcik <[email protected]> Co-authored-by: Luccas Castro <[email protected]> Co-authored-by: Adam Wójcik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
⭐ enhancement
New feature or request
💪 good first issue
Good for newcomers
👨💻work in progress
I am working on it
🎯 Aim of the feature
We should extend the extension settings to allow to:
👣 How to start guide
extension settings are defined in the package.json. We should extend it with two new settings
we should move the getExtensionSettings to a separate util file and refactor the
TerminalCommandExecuter
to use this utilthen in the
CommandPanel
we should modify theaccountTreeView
andappcatalogTreeView
to execute theCliActions
only if the setting is set to make those information visibleThe text was updated successfully, but these errors were encountered: